Http Client made consistent with Default Proxy Configurations #4957
Conversation
joviegas
force-pushed
the
joviegas/proxy_config_consistent
branch
from
a6e96b3 to
568de43
Compare
joviegas
force-pushed
the
joviegas/proxy_config_consistent
branch
from
568de43 to
296dbc1
Compare
joviegas
force-pushed
the
joviegas/proxy_config_consistent
branch
from
df13605 to
4d2e472
Compare
| } | ||
|
|
||
| public static Stream<Arguments> proxyConfigurationSettingWithConnectionFails() { | ||
| return Stream.of( |
There was a problem hiding this comment.
Can we create a TestCase class to contain the arguments? It's hard just looking at these nested lists what they're meant to be.
Also can we reconsider renaming this method? It's not really clear what these configs are. These are "incorrect" proxy configs right?
...t-tests/src/main/java/software/amazon/awssdk/http/proxy/HttpClientDefaultPoxyConfigTest.java
Show resolved
Hide resolved
...ent/src/test/java/software/amazon/awssdk/http/apache/ApacheClientProxyConfigurationTest.java
Outdated
Show resolved
Hide resolved
...t-tests/src/main/java/software/amazon/awssdk/http/proxy/HttpClientDefaultPoxyConfigTest.java
Outdated
Show resolved
Hide resolved
| import software.amazon.awssdk.testutils.EnvironmentVariableHelper; | ||
| import software.amazon.awssdk.utils.Pair; | ||
|
|
||
| public abstract class HttpClientDefaultProxyConfigTestSuite { |
There was a problem hiding this comment.
Can we close the HTTP client after the test is done? More specially, all CRT tests would fail if there are CRT resources that are not cleaned up.
There was a problem hiding this comment.
Done, note that I am not closing in @afterEach because we need to createClient for each test cases where each test case has unique system properties /env variable thus we need new createClient for each test cases. We delete it in same test case
…roxy Host settings
…ive of Proxy Host settings" This reverts commit f64ecc1.
|
* Http Client made consistent with Default Proxy Configurations * made changes for URL client * Updated test case Name * Updated comments related to test cases * Updated change logs
3 participants
Motivation and Context
#4745
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License