Address minor code quality issues in http-auth-aws

[gosar]

Motivation and Context

Addressing sonar cloud reported issues from merging feature/master/sra-identity-auth to master in #4509 - https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&pullRequest=4509&resolved=false&types=BUG.

Modifications

• Made some numeric literals long explicitly.
• Call Optional#isPresent() before accessing the value
• Added synchronized to match parent methods. (did not do it for SdkLengthAwareInputStream as it caused spotbugs failure)

Testing

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[gosar]

These changes cause findbugs failures. See https://github.com/aws/aws-sdk-java-v2/actions/runs/6500168283/job/17654999932?pr=4588#step:3:67245

Error:  Medium: Inconsistent synchronization of software.amazon.awssdk.http.auth.aws.internal.signer.io.SdkLengthAwareInputStream.length; locked 50% of time [software.amazon.awssdk.http.auth.aws.internal.signer.io.SdkLengthAwareInputStream, software.amazon.awssdk.http.auth.aws.internal.signer.io.SdkLengthAwareInputStream, software.amazon.awssdk.http.auth.aws.internal.signer.io.SdkLengthAwareInputStream, software.amazon.awssdk.http.auth.aws.internal.signer.io.SdkLengthAwareInputStream] Unsynchronized access at SdkLengthAwareInputStream.java:[line 60]Unsynchronized access at SdkLengthAwareInputStream.java:[line 46]Synchronized access at SdkLengthAwareInputStream.java:[line 92]Synchronized access at SdkLengthAwareInputStream.java:[line 98] IS2_INCONSISTENT_SYNC

[gosar]

Undoing this change in 7a8c647

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

77.8% Coverage
0.9% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint