Add used but undeclared dependencies to pom.xmls #4539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From SigV4DataFramePublisher which is SdkInternalApi.
From multiple classes in software.amazon.awssdk.http.auth.aws.crt.internal.
For derived attributes feature of signer ExecutionAttributes.
From AwsSignerExecutionAttributeTest
Just for NoAuthAuthScheme.SCHEME_ID in AwsExecutionContextBuilder.
cenedhryn
reviewed
Oct 4, 2023
| <artifactId>aws-json-protocol</artifactId> | ||
| <version>${awsjavasdk.version}</version> | ||
| </dependency> | ||
| <dependency> |
Contributor
There was a problem hiding this comment.
Will new services get this dependency from this point on?
Contributor
Author
There was a problem hiding this comment.
yes, added to the feature branch in #4309
As it was causing CrtBasedChecksumTest in sdk-core to fail as it expects to not find crt in the classpath.
cenedhryn
approved these changes
Oct 4, 2023
|
SonarCloud Quality Gate failed.
|
gosar
commented
Oct 12, 2023
Comment on lines
+84
to
+88
| <dependency> | ||
| <groupId>software.amazon.eventstream</groupId> | ||
| <artifactId>eventstream</artifactId> | ||
| <version>${eventstream.version}</version> | ||
| </dependency> |
Contributor
Author
There was a problem hiding this comment.
This should have been an optional dependency like http-auth-aws-eventstream above, so all customers of http-auth-aws don't bring in eventstream unless they are using event streaming features. Fixing in #4574.
aws-sdk-java-automation
added a commit
that referenced
this pull request
Dec 1, 2025
…f4d0246e4 Pull request: release <- staging/0d504f75-1cd6-41e9-9b22-2e3f4d0246e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Searched for "Used undeclared dependencies found:" in the build logs. Fixed 4/6.
One was in old-client-version-compatibility-test which is a test module, so didn't bother.
Another one was for aws-crt dependency from http-auth-aws, but adding it was causing some tests to fail, so reverted that.
Modifications
Added missing dependencies. In one case changed a test to avoid a test dependency.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License