Disable S3 payload signing.

[millems]

This is currently redundant, but when useSraAuth is made true, it will ensure that payload signing remains disabled.

[gosar]

Pre SRA does customer have a way to enable payload signing? Thought being, that if there's a way, maybe have a test that confirms that still works.

With SRA, I think customer can enable payload signing like this -

aws-sdk-java-v2/test/auth-tests/src/it/java/software/amazon/awssdk/sra/ia/SraIdentityAuthTest.java

Line 254 in 4df21e8

void sraS3PayloadSigningOnByDefault() {

(from branch used for surface area review), which I think should still work with this due to putAttributeIfAbsent.

[millems]

Pre SRA does customer have a way to enable payload signing? Thought being, that if there's a way, maybe have a test that confirms that still works.

Yes, via interceptors. That's tested in the backwards-compatibility changes I pushed yesterday, but it's not actually tested with the latest changes but useSraAuth = false. Let me add a test for that...

[gosar]

Yes, via interceptors.

yeah, I was wondering if there's another supported way (sounds like no), since the S3SignerExecutionAttribute.ENABLE_PAYLOAD_SIGNING is SdkProtectedApi. But yeah, we still want to make sure it continues to work, so the test is good.

With SRA there will be a publicly supported way via SignerProperty! We should add a test for that (non-blocking right now).

My ship it stands anyways!

[sonarqubecloud]

SonarCloud Quality Gate failed.   

4 Bugs
0 Vulnerabilities
2 Security Hotspots
473 Code Smells

84.2% Coverage
4.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint