Skip to content

Conversation

@gosar
Copy link
Contributor

@gosar gosar commented Sep 19, 2023

Motivation and Context

AwsV4FamilyHttpSigner not being an actual HttpSigner could be confusing. This is a followup from offline discussion of #4396 (comment).

Modifications

  • Make AwsV4FamilyHttpSigner extends HttpSigner, but use generic for Identity type, to leave the door open in case another implementation of V4 uses different type.
  • Remove extends HttpSigner from the V4 and V4a signers.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar requested a review from a team as a code owner September 19, 2023 21:57
@gosar gosar requested a review from zoewangg September 19, 2023 21:59
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 412 Code Smells

84.6% 84.6% Coverage
3.8% 3.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gosar gosar merged commit c96a6e4 into feature/master/sra-identity-auth Sep 20, 2023
@gosar gosar deleted the gosar/sra-ia-signer-parent branch September 20, 2023 04:24
aws-sdk-java-automation added a commit that referenced this pull request Oct 31, 2025
…3fbfabf51

Pull request: release <- staging/aade28c9-8da4-4b08-bde9-e4b3fbfabf51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants