-
Notifications
You must be signed in to change notification settings - Fork 1k
Add support for presigned DeleteObject #4313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "feature", | ||
| "category": "Amazon S3", | ||
| "contributor": "", | ||
| "description": "Add support for presigned `DeleteObject` in `S3Presigner`." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
138 changes: 138 additions & 0 deletions
138
...n/java/software/amazon/awssdk/services/s3/presigner/model/DeleteObjectPresignRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package software.amazon.awssdk.services.s3.presigner.model; | ||
|
|
||
| import java.time.Duration; | ||
| import java.util.function.Consumer; | ||
| import software.amazon.awssdk.annotations.Immutable; | ||
| import software.amazon.awssdk.annotations.NotThreadSafe; | ||
| import software.amazon.awssdk.annotations.SdkInternalApi; | ||
| import software.amazon.awssdk.annotations.SdkPublicApi; | ||
| import software.amazon.awssdk.annotations.ThreadSafe; | ||
| import software.amazon.awssdk.awscore.presigner.PresignRequest; | ||
| import software.amazon.awssdk.services.s3.model.DeleteObjectRequest; | ||
| import software.amazon.awssdk.services.s3.presigner.S3Presigner; | ||
| import software.amazon.awssdk.utils.Validate; | ||
| import software.amazon.awssdk.utils.builder.CopyableBuilder; | ||
| import software.amazon.awssdk.utils.builder.ToCopyableBuilder; | ||
|
|
||
| /** | ||
| * A request to pre-sign a {@link DeleteObjectRequest} so that it can be executed at a later time without requiring additional | ||
| * signing or authentication. | ||
| * | ||
| * @see S3Presigner#presignDeleteObject(DeleteObjectPresignRequest | ||
| * @see #builder() | ||
| */ | ||
| @SdkPublicApi | ||
| @Immutable | ||
| @ThreadSafe | ||
| public final class DeleteObjectPresignRequest extends PresignRequest | ||
| implements ToCopyableBuilder<DeleteObjectPresignRequest.Builder, DeleteObjectPresignRequest> { | ||
| private final DeleteObjectRequest deleteObjectRequest; | ||
|
|
||
| protected DeleteObjectPresignRequest(DefaultBuilder builder) { | ||
| super(builder); | ||
| this.deleteObjectRequest = Validate.notNull(builder.deleteObjectRequest, "deleteObjectRequest"); | ||
| } | ||
|
|
||
| /** | ||
| * Retrieve the {@link DeleteObjectRequest} that should be presigned. | ||
| */ | ||
| public DeleteObjectRequest deleteObjectRequest() { | ||
| return deleteObjectRequest; | ||
| } | ||
|
|
||
| @Override | ||
| public Builder toBuilder() { | ||
| return new DefaultBuilder(this); | ||
| } | ||
|
|
||
| /** | ||
| * Create a builder that can be used to create a {@link DeleteObjectPresignRequest}. | ||
| * | ||
| * @see S3Presigner#presignDeleteObject(DeleteObjectPresignRequest) | ||
| */ | ||
| public static Builder builder() { | ||
| return new DefaultBuilder(); | ||
| } | ||
|
|
||
|
dagnir marked this conversation as resolved.
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| if (!super.equals(o)) { | ||
| return false; | ||
| } | ||
|
|
||
| DeleteObjectPresignRequest that = (DeleteObjectPresignRequest) o; | ||
|
|
||
| return deleteObjectRequest.equals(that.deleteObjectRequest); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| int result = super.hashCode(); | ||
| result = 31 * result + deleteObjectRequest.hashCode(); | ||
| return result; | ||
| } | ||
|
|
||
| @SdkPublicApi | ||
| @NotThreadSafe | ||
| public interface Builder extends PresignRequest.Builder, | ||
| CopyableBuilder<DeleteObjectPresignRequest.Builder, DeleteObjectPresignRequest> { | ||
| Builder deleteObjectRequest(DeleteObjectRequest deleteObjectRequest); | ||
|
|
||
| default Builder deleteObjectRequest(Consumer<DeleteObjectRequest.Builder> deleteObjectRequest) { | ||
| DeleteObjectRequest.Builder builder = DeleteObjectRequest.builder(); | ||
| deleteObjectRequest.accept(builder); | ||
| return deleteObjectRequest(builder.build()); | ||
| } | ||
|
|
||
| @Override | ||
| Builder signatureDuration(Duration signatureDuration); | ||
|
|
||
| @Override | ||
| DeleteObjectPresignRequest build(); | ||
| } | ||
|
|
||
|
dagnir marked this conversation as resolved.
|
||
| @SdkInternalApi | ||
| private static final class DefaultBuilder extends PresignRequest.DefaultBuilder<DefaultBuilder> implements Builder { | ||
| private DeleteObjectRequest deleteObjectRequest; | ||
|
|
||
| private DefaultBuilder() { | ||
| } | ||
|
|
||
| private DefaultBuilder(DeleteObjectPresignRequest deleteObjectPresignRequest) { | ||
| super(deleteObjectPresignRequest); | ||
| this.deleteObjectRequest = deleteObjectPresignRequest.deleteObjectRequest; | ||
| } | ||
|
|
||
| @Override | ||
| public Builder deleteObjectRequest(DeleteObjectRequest deleteObjectRequest) { | ||
| this.deleteObjectRequest = deleteObjectRequest; | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public DeleteObjectPresignRequest build() { | ||
| return new DeleteObjectPresignRequest(this); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.