Attach crossRegionAccessEnabled as CustomClientParams to a client Builder, also mention of Composers are renamed as decorators

[joviegas]

Attach crossRegionAccessEnabled as CustomClientParams to a client Builder, also mention of Composers are renamed as decorators

Motivation and Context

S3Client.builder().crossRegionAccessEnabled(true).build();

1. Attach crossRegionAccessEnabled to Client Builder directly.
2. Removed crossRegionAccessEnabled from S3Configuration.
3. Customization to support Custom Client Params in customization.config
4. Rename Composers as Decorators
5. Remove the Type Casting in the Decorators (earlier known as composers)

Modifications

1. Codegen to support new Client Custom Param context
2. Remove generic type and interface for Composers
3. Replace Composers as decorators
4. Remove crossRegionAccessEnabled API from S3Configuration

Testing

1. Junits added .

License

• I confirm that this pull request can be released under the Apache 2 license

[millems]

Is there a reason we support both places? Is it hard to not support it in S3ClientConfiguration?

[joviegas]

The reason it is supported in both places is that the existing S3ClientContextParams are available in both locations. To access the values of these context parameters, they are accessed through getters on the S3Configuration.

        if (serviceConfigBuilder.crossRegionAccessEnabled() != null) {
            Validate.validState(Throw Exception in both places);
        } else {
            serviceConfigBuilder.crossRegionAccessEnabled(clientContextParams
                    .get(S3ClientContextParams.CROSS_REGION_ACCESS_ENABLED));
        }

What if the user wants to create a Config object solely to set the Client config in that S3 Configuration?"

"Is it difficult to not support it in S3ClientConfiguration?"

"It's not that difficult. We need to pass ContextParams to the decorator along with the service configuration to determine if it's a cross-region request."

"If we do not support this in S3Configuration, we will not be able to group it along with other client settings like useArnRegionEnabled, multiRegionEnabled, etc."

[joviegas]

Done ,removed it from S3ClientConfiguration

[millems]

Can you review the sonar bugs and mark them as a false positive or fix them?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
52 Code Smells

88.1% Coverage
1.3% Duplication