-
Notifications
You must be signed in to change notification settings - Fork 965
Document API for DynamoDB usung EnhancedDynamoDB impementation issue #36 #3849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding new Interface EnhancedDocument * Fix review comments from Anna-karin and David * Addresed Zoe's comment
* DefaultEnhancedDocument implementation * Updated Null check in the conveter itself while iterating Arrays of AttributeValue * handled review comments * Update test cases for JsonAttributeCOnverter * Removed ctor and added a builder * Removed ctor for toBuilder
* DocumentTableSchema Implementation * Handle review comments -1 * Handle review comments 2
…h attribute converters are added to it (#3780)
…3811) * TableSchema API to create table and functional tests * Surface API Review * Surface API Review - compilation issues * Surface API Review - Review comments * Surface API Review comments from Matt * Compilation issue and toStringMethod for JsonNode * Updated after handling Matt's comments * Functional Test added * Update in test cases * Removed functional tests , will create new PR for this * Review comments handled * Explicutly adding the dependency in th pom.xml * Removed @code from @snippet line in javadoc
* Remove extra spaces in Json and make it same as Items as in V1 * Moved Json string helper functions to seperate class
…omments (#3843) * Functional Test Cases for Document DDB API and Surface API Review 2 comments * Removed extra newlines from test cases * Handled Review comments * Removed primitive boolean getter and replaced with Boolean getter * Spotbug issue fixed and using StringUtils * StringUtils corrected the right package * Sonar quebe test bug fixed
dagnir
reviewed
Mar 20, 2023
...wssdk/enhanced/dynamodb/converters/document/CustomAttributeForDocumentConverterProvider.java
Outdated
Show resolved
Hide resolved
zoewangg
reviewed
Mar 20, 2023
...hanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/document/EnhancedDocument.java
Outdated
Show resolved
Hide resolved
...java/software/amazon/awssdk/enhanced/dynamodb/internal/document/DefaultEnhancedDocument.java
Outdated
Show resolved
Hide resolved
...java/software/amazon/awssdk/enhanced/dynamodb/internal/document/DefaultEnhancedDocument.java
Outdated
Show resolved
Hide resolved
...java/software/amazon/awssdk/enhanced/dynamodb/internal/document/DefaultEnhancedDocument.java
Outdated
Show resolved
Hide resolved
...anced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/mapper/DocumentTableSchema.java
Show resolved
Hide resolved
...anced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/mapper/DocumentTableSchema.java
Show resolved
Hide resolved
...anced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/mapper/DocumentTableSchema.java
Outdated
Show resolved
Hide resolved
zoewangg
approved these changes
Mar 22, 2023
...ced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/document/DocumentTableSchema.java
Outdated
Show resolved
Hide resolved
dagnir
approved these changes
Mar 23, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.








Motivation and Context
Fix for #36
Modifications
Creating SCHEMA with Primary and secondary keys
Simple Creation of EnhancedDocument using Builder
Put Item to table with simpleDoc as created above
Put Item to table with EnhancedDocument builder
Get Item from table
Testing
Screenshots (if appropriate)
Types of changes
License