Skip to content

Conversation

@gosar
Copy link
Contributor

@gosar gosar commented Mar 6, 2023

Motivation and Context

Minor updates to #3773

Modifications

  • Simplified hashCode/equals in ResolveIdentityRequest
  • Fixed broken doc link similar to changes in other AWS credentials classes

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar requested a review from a team as a code owner March 6, 2023 21:09
@gosar gosar mentioned this pull request Mar 6, 2023
12 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

42.6% 42.6% Coverage
0.0% 0.0% Duplication

@gosar gosar merged commit aa6afee into feature/master/sra-identity-auth Mar 9, 2023
@gosar gosar deleted the gosar/sra-ia-identity-fixes branch March 9, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants