Closed
Conversation
dave-fn
commented
Oct 7, 2022
Comment on lines
+81
to
+86
| try { | ||
| URI endpoint = new URI(request.protocol(), request.host(), null, null); | ||
| executionContext.metricCollector().reportMetric(CoreMetric.SERVICE_ENDPOINT, endpoint); | ||
| } catch (URISyntaxException e) { | ||
| throw new IllegalArgumentException(e); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Catching and rethrowing exception to not change method signature.
URI.create does not throw exception, but requires parsing a string.
|
SonarCloud Quality Gate failed. |
Contributor
Author
|
Closed due to waiting for endpoint 2.0 implementation, as that would be the optimal solution. Continuing work with #3775 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Provide a service endpoint metric to match the SDK v1 behavior as described with issue 2579.
Modifications
Created
SERVICE_ENDPOINTinCoreMetricfor returning anURI.Modified
BaseClientHandlerto report this new metric once an HTTP request has been built.Testing
Tested under
CoreMetricsTest. Also added assert to ignored test inBaseAsyncCoreMetricsTest.Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License