Expose tlsNegotiationTimeout for netty client #2806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
force-pushed
the
zoewang/NettyTlsNegotiationTimeout
branch
from
a40f7a6 to
fa21b54
Compare
cenedhryn
reviewed
Oct 29, 2021
http-client-spi/src/main/java/software/amazon/awssdk/http/SdkHttpConfigurationOption.java
Outdated
Show resolved
Hide resolved
cenedhryn
reviewed
Oct 29, 2021
Contributor
cenedhryn
left a comment
cenedhryn
left a comment
There was a problem hiding this comment.
What's the current default value of the TLS negotiation timeout?
Contributor
Author
|
The current default value of the TLS negotiation timeout is 10s in netty and that's why I kept it 10s here as well |
|
SonarCloud Quality Gate failed. |
cenedhryn
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is to utilize the tlsNegotiationTimeout from the future
sdk-default-configuration.jsonApache HTTP client 4.x and URLConnection currently don't support handshake timeout
Description
Expose tlsNegotiationTimeout for netty client to allow users configure it.
Testing
Added unit tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense