private/protocol/query: Add parsing of ServiceUnavailableException #596
Conversation
Adds support to fallback and attempt to parse the ServiceUnavailableException out of the response body. This is helpful when the request failed and the service returned unavailable error. Previously the error unmarshaller would fail with a serialization error. Fix #331
|
|
||
| // Check for unhandled error | ||
| servUnavailResp := xmlServiceUnavailableResponse{} | ||
| unavailErr := xml.Unmarshal(bodyBytes, &servUnavailResp) |
There was a problem hiding this comment.
Wouldn't it be possible to just update
type xmlErrorResponse struct {
XMLName xml.Name `xml:"ErrorResponse,ServiceUnavailableException"`
Code string `xml:"Error>Code"`
Message string `xml:"Error>Message"`
RequestID string `xml:"RequestId"`
}then check the name rather than unmarshal twice?
There was a problem hiding this comment.
Interesting didn't know you could do that with XML tags, ServiceUnavailableException isn't an attribute, but a different xml tag than ErrorResponse.
I'm not sure if xml can do that. I didn't see any mention of it in the godoc, and this play example hits an error, http://play.golang.org/p/NCECBedwc5
There was a problem hiding this comment.
You are right. We could just get rid of the ErrorResponse and ServiceUnavailableException and just check the name that way? But I don't know if I like that, what do you think?
Other than that, 
!
There was a problem hiding this comment.
Removing the name tag all together might work if the only tags were ErrorResponse or ServiceUnavailableException i think. If there were any other tag before the two error tags that we are expecting I think the xml will not unmarshal the error we're actually looking for. The additional unmarshal should be an extremely rare event and only occurs if ErrorResponse failed to parse the error body.
There was a problem hiding this comment.
Okay, thanks for the clarification. LGTM
private/protocol/query: Add parsing of ServiceUnavailableException
Adds support to fallback and attempt to parse the
ServiceUnavailableException out of the response body. This is helpful
when the request failed and the service returned unavailable error.
Previously the error unmarshaller would fail with a serialization error.
Fix #331