S3 Download manager should handle no Content Range and Length for first chunk #419
Assignees
Labels
bug
This issue is a bug.
Comments
jasdel
referenced
this issue
Nov 3, 2015
Fixes a bug when the S3 object being download is not chunked and the full contents are provided in the response. Content-Range header will not be provided, and S3 Download manager needs to fallback to Content-Length instead to get the total length of the object. Fix # 417
xibz
pushed a commit
to xibz/aws-sdk-go
that referenced
this issue
Jan 15, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now for the first chunk
downloader's usessetTotalBytesto determine if it should sleep while waiting for the first chunk's response before requesting the subsequent chunks concurrently. If the total bytes are not updated by thesetTotalBytesthedownloader.download()the first chunk will never be seen as completed. In this case the download manager should fallback to disabling its concurrency and download the object one chunk at a time since it doesn't know the total size to divide the object into.The text was updated successfully, but these errors were encountered: