Remove deprecated nimble service #2822
Conversation
| "type": "feature", | ||
| "description": "Remove deprecated `nimble` service.", | ||
| "modules": [ | ||
| "." |
There was a problem hiding this comment.
nit: shouldn't this be scoped to nimble instead of .?
There was a problem hiding this comment.
So technically the nimble module is being deleted -- I'm not sure if our tooling is written to handle that as an edge case. I suspect it will try to go update service/nimble/CHANGELOG.md to include this new entry, but that file wouldn't exist anymore since we deleted it, so the release would probably explode.
The other problem we have (recently noted in #2819, not directly although I think this is another case of that) is that a changelog like this bumps the root SDK module for basically no reason (no actual change) which by proxy bumps every service client module for equally no reason.
TL;DR not sure what to do here. Let's discuss internally. We should honestly probably just not have a changelog for these types of deprecations for now.
There was a problem hiding this comment.
involved modules are generated by changelog cmd according to which commit we use, here I passed the commit including both model and service api removal
No description provided.