Upgrade to Smithy 1.26.x #1920
Closed
Upgrade to Smithy 1.26.x #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
upgrade-smithy-1.26.x
branch
2 times, most recently
from
ce0c9b9 to
b4a289c
Compare
added 2 commits
November 11, 2022 13:54
Update serializing empty lists for query protocols (see references)
to pass protocol tests.
Previous Behavior:
`{ "ListArg": [] }` serializes to ``.
Current Behavior:
`{ "ListArg": [] }` serializes to `?ListArg=`.
References:
- smithy-lang/smithy#1444
- [AWS query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-query-protocol.html)
- [AWS EC2 query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-ec2-query-protocol.html)
syall
force-pushed
the
upgrade-smithy-1.26.x
branch
from
b4a289c to
96308bf
Compare
syall
force-pushed
the
upgrade-smithy-1.26.x
branch
from
ebe428a to
fe622a4
Compare
syall
commented
Nov 12, 2022
Comment on lines
2452
to
2456
| if len(v) == 0 { | ||
| value.Array("member").Empty() | ||
| return nil | ||
| } | ||
| array := value.Array("member") |
There was a problem hiding this comment.
Or maybe this generated code makes more sense?
Suggested change
| if len(v) == 0 { | |
| value.Array("member").Empty() | |
| return nil | |
| } | |
| array := value.Array("member") | |
| array := value.Array("member") | |
| if len(v) == 0 { | |
| array.Empty() | |
| return nil | |
| } |
|
Closed in favor of #1996. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE MERGING: Make sure client serializers have no merge conflicts.
Description of changes:
The following changes are included in this PR:
Upgrade to smithy 1.26.x using a version range.
Update serializing empty lists for query protocols (see references) to pass protocol tests.
Previous Behavior:
{ "ListArg": [] }serializes to ``.Current Behavior:
{ "ListArg": [] }serializes to?ListArg=.Protocol tests are regenerated
Client serializers that use query protocols are regenerated
References:
Testing:
makemake unit-modules-internal_protocoltestFor changes to files under the
/codegen/aws-modelsfolder, and manual edits to autogenerated code (e.g./service/s3/api.go) please create an Issue instead of a PR for those type of changes.N/A
If there is an existing bug or feature this PR is answers please reference it here.
N/A
To help speed up the process and reduce the time to merge please ensure that
Allow edits and access to secrets by maintainersis checked before submitting your PR. This will allow the project maintainers to make minor adjustments or improvements to the submitted PR, allow us to reduce the roundtrip time for merging your request.N/A