Fix bug that prevented some operations and service clients from resolving a service endpoint #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
changed the title
skotambkar
reviewed
Jul 19, 2021
...n/src/main/java/software/amazon/smithy/aws/go/codegen/RegisterServiceMetadataMiddleware.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/software/amazon/smithy/aws/go/codegen/RegisterServiceMetadataMiddleware.java
Outdated
Show resolved
Hide resolved
skotambkar
approved these changes
Jul 19, 2021
… from resolving a service endpoint.
skotambkar
approved these changes
Jul 19, 2021
jrichard8
pushed a commit
to jrichard8/aws-sdk-go-v2
that referenced
this pull request
Feb 14, 2022
…ving a service endpoint (aws#1349)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a code generation which prevented the
RegisterServiceMetadatafrom being added to the stack for one or more operations in the following service clients:Failure to include this middleware resulted in users receiving an error message of
failed to resolve service endpoint, an AWS region is required, but was not found.Fixes: #1325
Fixes: #1260