Repository navigation
fix cancel s3crt request callback to not outlive request lifetime - #3643
Merged
Merged
Conversation
sbiscigl
marked this pull request as ready for review
December 5, 2025 17:38
pulimsr
approved these changes
Dec 5, 2025
sbiscigl
force-pushed
the
crt-cancel-request
branch
from
December 5, 2025 18:47
df6a575 to
633c588
Compare
DmitriyMusatkin
approved these changes
Dec 5, 2025
sbiscigl
force-pushed
the
crt-cancel-request
branch
2 times, most recently
from
December 5, 2025 20:33
7116785 to
f16a2ee
Compare
sbiscigl
force-pushed
the
crt-cancel-request
branch
from
December 8, 2025 14:49
f16a2ee to
cc0f91e
Compare
9 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3639
Description of changes:
there is a problem with the method
CancelCrtRequestAsync. In that method we use the sdk thread executor to spin up a cancel requestif the request finished before that cleanup request can be processed the cleanup with segfault.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.