Skip to content

fix cancel s3crt request callback to not outlive request lifetime - #3643

Merged
sbiscigl merged 1 commit into
mainfrom
crt-cancel-request
Dec 8, 2025
Merged

sbiscigl merged 1 commit into
mainfrom
crt-cancel-request

Conversation

@sbiscigl

@sbiscigl sbiscigl commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Issue #, if available:

#3639

Description of changes:

there is a problem with the method CancelCrtRequestAsync. In that method we use the sdk thread executor to spin up a cancel request

m_clientConfiguration.executor->Submit([meta_request]() { aws_s3_meta_request_cancel(meta_request); });

if the request finished before that cleanup request can be processed the cleanup with segfault.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl
sbiscigl marked this pull request as ready for review December 5, 2025 17:38
@sbiscigl
sbiscigl force-pushed the crt-cancel-request branch 2 times, most recently from 7116785 to f16a2ee Compare December 5, 2025 20:33
@sbiscigl
sbiscigl merged commit 9054af0 into main Dec 8, 2025
5 checks passed
@sbiscigl
sbiscigl deleted the crt-cancel-request branch December 8, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants