Add commented out logging test to repro logger use after free issue #3621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kai-ion
reviewed
Nov 12, 2025
| bool success = futures[i].get(); | ||
| ASSERT_TRUE(success); | ||
| } | ||
| } |
kai-ion
approved these changes
Nov 12, 2025
pulimsr
approved these changes
Nov 12, 2025
sbaluja
force-pushed
the
loggerUseAfterFreeTest
branch
from
f4d52de to
a90040b
Compare
sbaluja
force-pushed
the
loggerUseAfterFreeTest
branch
from
a90040b to
9e1d800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3607
Description of changes:
Adding a commented out test that reproduces the use after free scenario with the CRTLogger
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.