Conversation
SergeyRyabinin
force-pushed
the
sr/pr2293rebased
branch
from
53488f9 to
95739dd
Compare
sbiscigl
approved these changes
Mar 3, 2023
sdavtaker
reviewed
Mar 6, 2023
CMakeLists.txt
Outdated
| option(BUILD_SHARED_LIBS "If enabled, all aws sdk libraries will be build as shared objects; otherwise all Aws libraries will be built as static objects" ON) | ||
| option(FORCE_SHARED_CRT "If enabled, will unconditionally link the standard libraries in dynamically, otherwise the standard library will be linked in based on the BUILD_SHARED_LIBS setting" ON) | ||
| option(SIMPLE_INSTALL "If enabled, removes all the additional indirection (platform/cpu/config) in the bin and lib directories on the install step" ON) | ||
| option(USE_CRT_HTTP_CLIENT "If enabled, The common runtime HTTP client will be used, and the legacy systems such as WinHttp and libcurl will not be built or included" OFF) |
Contributor
There was a problem hiding this comment.
Typo after comma.
If enabled, The common runtime HTTP
should be
If enabled, the common runtime HTTP
| #include <aws/core/config/AWSProfileConfigLoader.h> | ||
| #include <aws/core/internal/AWSHttpResourceClient.h> | ||
|
|
||
| #include <aws/crt/Api.h> |
Contributor
There was a problem hiding this comment.
Should we wrap this in conditional compile path?
Contributor
Author
There was a problem hiding this comment.
that's "AWS-CRT-CPP" wrapper, not the http client from CRT.
| m_client = Aws::MakeUnique<TranscribeStreamingServiceClient>(ALLOC_TAG, config); | ||
| m_clientWithWrongCreds = Aws::MakeUnique<TranscribeStreamingServiceClient>(ALLOC_TAG, Aws::Auth::AWSCredentials("a", "b"), config); | ||
| config.endpointOverride = "https://0xxxabcdefg123456789.com"; | ||
| //config.endpointOverride = "https://0xxxabcdefg123456789.com"; |
Contributor
There was a problem hiding this comment.
if no longer used, we should remove this line
sdavtaker
approved these changes
Mar 6, 2023
sdavtaker
force-pushed
the
sr/pr2293rebased
branch
from
e1ca6d2 to
6932274
Compare
sdavtaker
force-pushed
the
sr/pr2293rebased
branch
from
6932274 to
7ccabd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
A rebase of
Crt http integration #2293
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.