Fixed runtime container working directory bug #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
string if the CodeUri was set to something that wasn't a valid directory. Wrote a load of test cases for working directory related stuff to prevent future regressions. Fixes #22
PaulMaddox
commented
Aug 18, 2017
| @@ -584,7 +584,7 @@ func getWorkingDir(basedir string, codeuri string, checkWorkingDirExist bool) (s | |||
| if _, err := os.Stat(dir); err != nil { | |||
| // It doesn't, so just use the directory of the SAM template | |||
| // which might have been passed as a relative directory | |||
| dir = basedir | |||
| dir = abs | |||
There was a problem hiding this comment.
This was the cause of the bug.
If the base directory was empty (e.g. if they called --template filename.yaml), and the CodeUri wasn't a valid relative directory that exists, then instead of returning the current working directory, it returned "".
|
Travis build 👍🏼 |
sanathkr
approved these changes
Aug 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed runtime container working directory that caused it to be an empty string if the CodeUri was set to something that wasn't a valid directory.
Wrote a load of test cases for working directory related stuff to prevent future regressions.
Fixes #22