Update environment variable name for debugger arguments #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update env var name
- Update readme to reflect env var name change
Contributor
|
Thanks for making the code change. Unfortunately, AWS Cloud9 relies heavily on this environment variable to setup Python debugging. So we cannot really change the name of the env var. So can you simply fix the docs instead? |
sanathkr
added
stage/in-review
stage/in-progress
Contributor
Author
|
Superseded by #399 |
qingchm
pushed a commit
to qingchm/aws-sam-cli
that referenced
this pull request
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #359
Description of changes:
Documentation around environment variable was incorrect.
With SAM CLI re-written in python I have updated the environment variable name to be inline with other environment variable names,
SAM_DEBUGGER_ARGUMENTS.Use of this feature would be low and the impact of this change would be low as only those who read through the source code previously (or consulted the issue I opened) would have been able to use this feature as the instructions in the docs were incorrect.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.