Update README.md #368
Closed
Update README.md #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a duplicate statement
|
LGTM. Can you resolve conflict and resubmit? |
|
This change is not valid anymore because the readme was updated in another PR and fixed |
qingchm
pushed a commit
to qingchm/aws-sam-cli
that referenced
this pull request
Sep 17, 2021
* Reverted pylint to 2.6.x * Disables PyLint for Generic * Updated boto3-stubs * Fixed Another PyLint Generic Issue * Fixed Test Typing Issues * Fixed Python3.7 and 3.8 re.escape Test Issue * Added ECR Login
qingchm
pushed a commit
to qingchm/aws-sam-cli
that referenced
this pull request
Sep 17, 2021
* refactor for test command + some unit test fixes * remove some test command changes which accidentally went into refactor one * remove some test command changes which accidentally went into refactor one * sam test implementation and some groundwork * when neither payload nor payload_file is provided, it will use sys.stdin to read the payload * fix typo * use protocol instead of complex callable * use utf-8 for encoding * fix typo * use protocol instead of complex callable * address comments * address comments * feat(Accelerate): CI Fixes (aws#368) * Reverted pylint to 2.6.x * Disables PyLint for Generic * Updated boto3-stubs * Fixed Another PyLint Generic Issue * Fixed Test Typing Issues * Fixed Python3.7 and 3.8 re.escape Test Issue * Added ECR Login * fix unit tests * address comments * address comments * address comments * update log message * flip the flag back once we have new log group is created * feat: sam test lambda implementation (aws#366) * sam test lambda implementation * when neither payload nor payload_file is provided, it will use sys.stdin to read the payload * use utf-8 for encoding * fix typo * use protocol instead of complex callable * address comments & update with ability to pipe file input into test execution * feat: sam test sqs implementation (aws#367) * sam test sqs implementation * when neither payload nor payload_file is provided, it will use sys.stdin to read the payload * use utf-8 for encoding * fix typo * use protocol instead of complex callable * address comments & update with ability to pipe file input into test execution * address comments & update sqs test executor * added extra debug logging * address comments * address comments * make black Co-authored-by: Cosh_ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a duplicate statement
Issue #, if available:
Description of changes: It is a simple change in the grammar to remove a duplicate entry
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.