fix: Correction of integration tests for canary environments #3532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mndeveci
reviewed
Dec 16, 2021
| self.assertIn(warning_message, deploy_process_execute.stdout) | ||
| self.assertEqual(deploy_process_execute.process.returncode, 0) | ||
|
|
||
| def _method_to_stack_name(self, method_name): |
There was a problem hiding this comment.
Why we don't need this anymore?
There was a problem hiding this comment.
Same as above, why do we delete these methods?
There was a problem hiding this comment.
It is already in package's base class, this is a duplicate and missed imports caused some failures
There was a problem hiding this comment.
I refactored these methods to be shared together by sync and deploy through package base
mndeveci
approved these changes
Dec 16, 2021
mingkun2020
approved these changes
Dec 16, 2021
mndeveci
pushed a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Dec 17, 2021
jonife
pushed a commit
to jonife/aws-sam-cli
that referenced
this pull request
Dec 17, 2021
mndeveci
added a commit
that referenced
this pull request
Dec 18, 2021
* SAM INIT Update * resolved conflict * test added and updated * block default prompt when Image packageType is provide and skip use case prompt when --app-template is provided * update default hello world prompt * filtering updates * added typing * Fixing failed canaries (#3532) * (fix) stop resolving relative paths for Function image URI (#3531) * (fix) stop resolve relative paths for function imageUri * fix unit testing * update template_does_not_meet_filter_criteria use <dict>.get Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Qingchuan Ma <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]>
moelasmar
added a commit
to moelasmar/aws-sam-cli
that referenced
this pull request
Dec 22, 2021
* SAM INIT Update * resolved conflict * test added and updated * block default prompt when Image packageType is provide and skip use case prompt when --app-template is provided * update default hello world prompt * filtering updates * added typing * Fixing failed canaries (aws#3532) * (fix) stop resolving relative paths for Function image URI (aws#3531) * (fix) stop resolve relative paths for function imageUri * fix unit testing * update template_does_not_meet_filter_criteria use <dict>.get Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Qingchuan Ma <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]>
mndeveci
pushed a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Apr 5, 2022
mndeveci
added a commit
to mndeveci/aws-sam-cli
that referenced
this pull request
Apr 5, 2022
* SAM INIT Update * resolved conflict * test added and updated * block default prompt when Image packageType is provide and skip use case prompt when --app-template is provided * update default hello world prompt * filtering updates * added typing * Fixing failed canaries (aws#3532) * (fix) stop resolving relative paths for Function image URI (aws#3531) * (fix) stop resolve relative paths for function imageUri * fix unit testing * update template_does_not_meet_filter_criteria use <dict>.get Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Qingchuan Ma <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.