Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go 1.x support #266

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Add Go 1.x support #266

merged 1 commit into from
Jan 22, 2018

Conversation

mhart
Copy link
Contributor

@mhart mhart commented Jan 22, 2018

Fixes #264

@sanathkr sanathkr requested a review from PaulMaddox January 22, 2018 21:12
@sanathkr
Copy link
Contributor

Exciting! @PaulMaddox is giving this a spin before merging. Thanks @mhart for doing this!

PaulMaddox
PaulMaddox approved these changes Jan 22, 2018
View reviewed changes
Copy link
Contributor

@PaulMaddox PaulMaddox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @mhart!

@PaulMaddox
Copy link
Contributor

Tested the runtime locally with the CodeStar sample. Works great, will merge this and prep a SAM Local release.

@PaulMaddox
Copy link
Contributor

twiddles thumbs waiting for travis-ci to wake up...

@PaulMaddox PaulMaddox merged commit 3aeca93 into aws:develop Jan 22, 2018
@mhart mhart deleted the add-go1.x branch January 22, 2018 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulMaddox PaulMaddox PaulMaddox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhart @sanathkr @PaulMaddox