fix(type-safe-api): fix template discovery on node 18.17.x #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 18.17.x has a bug where `readdirSync` returns invalid entries when both `recursive` and `withFileTypes` is specified: nodejs/node#48858 We use our own implementation to recursively find template files to ensure we work for older versions of node.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bf9b347. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
agdimech
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 18.17.x has a bug where
readdirSyncreturns invalid entries when bothrecursiveandwithFileTypesis specified:nodejs/node#48858
We use our own implementation to recursively find template files to ensure we work for older versions of node.
NB the shapshots have changed due to the
.tsapi-manifestnow containing the file names in a different order.