Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integ-tests] Fix test_essential_features test #6584

Merged
merged 2 commits into from
Dec 4, 2024
Merged

[integ-tests] Fix test_essential_features test #6584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
320abfc
Remove date extension to onld rotated files
hgreebe Dec 2, 2024
33c2f29
Only check that remote_host is listed in mpi out array
hgreebe Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/integration-tests/tests/basic/log_rotation_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ def _test_logs_are_rotated(os, logs, remote_command_executor, before_log_rotatio
"sync",
compute_node_ip,
)
# remove date extension to old rotated file
_run_command_on_node(
remote_command_executor, "sudo sed -i 's/dateext/nodateext/g' /etc/logrotate.conf", compute_node_ip
)
# force log rotate without waiting for logs to reach certain size
_run_command_on_node(remote_command_executor, "sudo logrotate -f /etc/logrotate.conf", compute_node_ip)
# check if logs are rotated
Expand Down
2 changes: 0 additions & 2 deletions tests/integration-tests/tests/basic/test_essential_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ def _test_mpi_ssh(remote_command_executor, test_datadir, scheduler_commands_fact

# mpirun_out_ip = ["Warning: Permanently added '192.168.60.89' (ECDSA) to the list of known hosts.",
# '', 'ip-192-168-60-89']
assert_that(len(mpirun_out_ip)).is_equal_to(3)
assert_that(mpirun_out_ip[-1]).is_equal_to(remote_host)

mpirun_out = remote_command_executor.run_remote_script(
Expand All @@ -156,7 +155,6 @@ def _test_mpi_ssh(remote_command_executor, test_datadir, scheduler_commands_fact

# mpirun_out = ["Warning: Permanently added 'ip-192-168-60-89,192.168.60.89' (ECDSA) to the list of known hosts.",
# '', 'ip-192-168-60-89']
assert_that(len(mpirun_out)).is_equal_to(3)
assert_that(mpirun_out[-1]).is_equal_to(remote_host)


Expand Down
Loading