Refactor dna.json and use S3 to access these files #6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 11, 2024 18:01
…gle file * Refactoring ComputeFleet to download common_dna.json and compute resource specific dna * giving PutObject access to headnode for s3-do-not-delete bucket * rename common,headnode and compute dna json * Adding compute-dna.json and downloading it from S3 * Adding stack arn in a write file * Using config Version to download and upload json files specific to a cluster-config version so that we can rollback using the previous config version when needed * Reduce cfn-init for compute fleet to just mention files.This file is never created but a change in config version in AWS::CloudFormation::Init signifies an update * give listversionObject and ListBucketVersions access to compute node * Use cfn-init calls for Cluster Update Path and use cfn-init to create common-dna file for queues * Use cfn-init to create common-dna file for queues
himani2411
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+67
to
+68
| ":s3:::parallelcluster-a69601b5ee1fc2f2-v1-do-not-delete/" | ||
| "parallelcluster/clusters/dummy-cluster-randomstring123/*", |
Check warning
Code scanning / CodeQL
Implicit string concatenation in a list Warning test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
do-not-deletebucket from HeadNode using cookbookPutObjectaccess to HeadNode IAM roleGetObject, ListBucketto compute fleet nodeTests
Unit test -> test_cluster_config_limits
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.