Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Add support for FSx Lustre as a shared storage type in us-iso-east-1. #6242

Merged
merged 4 commits into from
May 23, 2024

Conversation

gmarciani
Copy link
Contributor

@gmarciani gmarciani commented May 15, 2024

PR in DRAFT because the support for FSxL in us-iso-east.-1 is still under validation

Description of changes

Added support for FSx Lustre as a shared storage type in us-iso-east-1.
Adapted integ tests accordingly.
Also disabled a linter rule on test_ad_integration

Tests

  • Unit tests verifying that the feature flag is removed.
  • E2E tests: test_dynamic_file_systems_update, test_dynamic_file_systems_update_rollback, test_shared_storage

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani force-pushed the wip/mgiacomo/310/fsx-lustre-adc branch from c53c8e6 to b02b882 Compare May 15, 2024 14:13
@gmarciani gmarciani force-pushed the wip/mgiacomo/310/fsx-lustre-adc branch 4 times, most recently from 812aafb to 81c2fae Compare May 17, 2024 13:09
hanwen-pcluste
hanwen-pcluste previously approved these changes May 17, 2024
@gmarciani gmarciani marked this pull request as ready for review May 22, 2024 18:19
@gmarciani gmarciani requested review from a team as code owners May 22, 2024 18:19
@gmarciani gmarciani force-pushed the wip/mgiacomo/310/fsx-lustre-adc branch from e06db48 to 6cd0e32 Compare May 23, 2024 08:44
@gmarciani gmarciani enabled auto-merge (rebase) May 23, 2024 12:42
@gmarciani gmarciani merged commit 39c30da into aws:develop May 23, 2024
28 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/310/fsx-lustre-adc branch May 23, 2024 15:02
hanwen-pcluste pushed a commit to hanwen-pcluste/aws-parallelcluster that referenced this pull request Jun 6, 2024
The import was mistakenly deleted by aws#6242

Signed-off-by: Hanwen <[email protected]>
hanwen-pcluste pushed a commit that referenced this pull request Jun 7, 2024
The import was mistakenly deleted by #6242

Signed-off-by: Hanwen <[email protected]>
gmarciani pushed a commit to gmarciani/aws-parallelcluster that referenced this pull request Jun 14, 2024
The import was mistakenly deleted by aws#6242

Signed-off-by: Hanwen <[email protected]>
gmarciani pushed a commit that referenced this pull request Jun 14, 2024
The import was mistakenly deleted by #6242

Signed-off-by: Hanwen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants