Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix][release3.8] Fix Login Nodes Feature does not set Tags bugs #5854

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Nov 16, 2023

Description of changes

  • Add custom Tags to LoginNodes stack Launch Template

Tests

  • Manually tests done, pass successfully. Now the LoginNodes Launch Template will correctly has custom Tags
  • Add new unit tests for this issue, pass successfully

References

  • N/A

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…s#5848)

* Fix Login Nodes Feature does not set Tags

* Add unit tests for custom tags in LoginNodes Launch Template
@hehe7318 hehe7318 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Nov 16, 2023
@hehe7318 hehe7318 requested review from a team as code owners November 16, 2023 04:06
@hehe7318 hehe7318 enabled auto-merge (squash) November 16, 2023 04:08
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (907e283) 90.00% compared to head (a4154dd) 90.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-3.8    #5854   +/-   ##
============================================
  Coverage        90.00%   90.00%           
============================================
  Files              180      180           
  Lines            15638    15638           
============================================
  Hits             14075    14075           
  Misses            1563     1563           
Flag Coverage Δ
unittests 90.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hehe7318 hehe7318 merged commit 0943efb into aws:release-3.8 Nov 16, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants