Skip to content

Commit

Permalink
[Test] In test_update_slurm, use flexible instance types for spot ins…
Browse files Browse the repository at this point in the history
…tances to reduce the risk of ICEs.

Signed-off-by: Giacomo Marciani <[email protected]>
  • Loading branch information
gmarciani committed Nov 28, 2024
1 parent 3119557 commit e8563ce
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 0 deletions.
18 changes: 18 additions & 0 deletions tests/integration-tests/tests/update/test_update.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,15 @@ def test_update_slurm(region, pcluster_config_reader, s3_bucket_factory, cluster
"instances": [
{
"instance_type": "t3.small",
},
{
"instance_type": "t3a.small",
},
{
"instance_type": "t3.medium",
},
{
"instance_type": "t3a.medium",
}
],
"expected_running_instances": 1,
Expand Down Expand Up @@ -240,6 +249,15 @@ def test_update_slurm(region, pcluster_config_reader, s3_bucket_factory, cluster
"instances": [
{
"instance_type": "t3.small",
},
{
"instance_type": "t3a.small",
},
{
"instance_type": "t3.medium",
},
{
"instance_type": "t3a.medium",
}
],
"expected_running_instances": 0,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ Scheduling:
- Name: queue1-i3 # New compute resource
Instances:
- InstanceType: t3.small
- InstanceType: t3a.small
- InstanceType: t3.medium
- InstanceType: t3a.medium
# Removed MinCount
Networking:
SubnetIds:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ Scheduling:
- Name: queue1-i2
Instances:
- InstanceType: t3.small
- InstanceType: t3a.small
- InstanceType: t3.medium
- InstanceType: t3a.medium
MinCount: 1
Networking:
SubnetIds:
Expand Down

0 comments on commit e8563ce

Please sign in to comment.