Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NFS installation on Ubuntu #1533

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

lukeseawalker
Copy link
Contributor

@lukeseawalker lukeseawalker commented Sep 22, 2022

Signed-off-by: Luca Carrogu [email protected]

Description of changes

This is a workaround for the issue in sous-chefs/nfs#93

Tests

Tested with the following conf

Image:
  Name: test-nfs
  RootVolume:
    Size: 35
Build:
  Iam:
    AdditionalIamPolicies:
      - Policy: arn:aws:iam::aws:policy/AmazonEC2ReadOnlyAccess
  InstanceType: -
  ParentImage: ami-0ee23bfc74a881de5
  Components:
    - Type: arn
      Value: arn:aws:imagebuilder:us-east-1:346106133209:component/nfs-test/3.2.0
  SecurityGroupIds:
    - ...
  SubnetId: ...
  UpdateOsPackages:
    Enabled: true
DevSettings:
  DisablePclusterComponent: true
  DistributionConfiguration:
    Regions: us-east-1
  TerminateInstanceOnFailure: false  

where
the component points to this branch containing the fix

References

sous-chefs/nfs#93

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This is a workaround for the issue in sous-chefs/nfs#93

Signed-off-by: Luca Carrogu <[email protected]>
@lukeseawalker lukeseawalker marked this pull request as ready for review September 22, 2022 10:58
@lukeseawalker lukeseawalker requested review from a team as code owners September 22, 2022 10:58
Copy link
Contributor

@francesco-giordano francesco-giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukeseawalker lukeseawalker merged commit d46e52c into aws:develop Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants