-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building with release tarball throws tuner_v1.h
not found error
#382
Comments
rajachan
added a commit
to rajachan/aws-ofi-nccl
that referenced
this issue
Apr 10, 2024
This was not caught in manual tests when a dist was built on a non-EC2 machine (or in Github Actions environment) since `WANT_PLATFORM_AWS` paths would not be enabled in the Makefile then. Fixes: aws#382 Signed-off-by: Raghu Raja <[email protected]>
rajachan
added a commit
to rajachan/aws-ofi-nccl
that referenced
this issue
Apr 11, 2024
Fixes aws#382 Signed-off-by: Raghu Raja <[email protected]>
Thanks for reporting the issue, @sirutBuasai. The release artifact was indeed missing the headers. We are working on a bugfix release that should address this issue. |
rajachan
added a commit
to rajachan/aws-ofi-nccl
that referenced
this issue
Apr 11, 2024
Fixes aws#382 Signed-off-by: Raghu Raja <[email protected]> (cherry picked from commit 3df302e)
rajachan
added a commit
that referenced
this issue
Apr 12, 2024
Fixes #382 Signed-off-by: Raghu Raja <[email protected]> (cherry picked from commit 3df302e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that there's some discrepancy between the release tarball (https://github.com/aws/aws-ofi-nccl/releases/download/v1.9.0-aws/aws-ofi-nccl-1.9.0-aws.tar.gz) and the source code tarball (https://github.com/aws/aws-ofi-nccl/archive/refs/tags/v1.9.0-aws.tar.gz). The release tarball doesn't contain
tuner_v*.h
files while the source code do.As such, building with release tarball throws the following error:
However, building using the source code tarball is successful when running the following:
The text was updated successfully, but these errors were encountered: