Remove unit test functions that mock ASG managed tag #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #654
Description of changes:
PR #669 removed calls to ASG APIs when checking for the "managed" tag on EC2 instances. Some of the unit tests were still testing that behavior, which is no longer necessary. This PR removes those functions.
A few of the unit tests do not need to set an
ASGparameter at all, so I removed those lines entirely. In tests that do need the ASG parameter, I left it but passed in a default ASG mock object.Testing:
Verified that unit tests pass after these changes. No changes made to functional production code, only unit tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.