Skip to content

Update README during release-prep instead of after release #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Update README during release-prep instead of after release #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,3 @@ jobs:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_SESSION_TOKEN: ${{ secrets.AWS_SESSION_TOKEN }}

- name: Create NTH README Update PR
run: make create-release-prep-pr-readme
3 changes: 0 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,6 @@ create-local-release-tag-patch:
create-release-prep-pr:
${MAKEFILE_PATH}/scripts/prepare-for-release

create-release-prep-pr-readme:
${MAKEFILE_PATH}/scripts/prepare-for-release -m

create-release-prep-pr-draft:
${MAKEFILE_PATH}/scripts/prepare-for-release -d

Expand Down
13 changes: 2 additions & 11 deletions scripts/prepare-for-release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ CHART=$REPO_ROOT_PATH/config/helm/aws-node-termination-handler/Chart.yaml
CURR_CHART_VERSION=$(cat $CHART | grep 'version:' | xargs | cut -d' ' -f2 | tr -d '[:space:]')
UPDATED_CHART_VERSION=""
CHART_VALUES=$REPO_ROOT_PATH/config/helm/aws-node-termination-handler/values.yaml
# ReadMe will be updated post-release due to long NTH release time
FILES=("$CHART" "$CHART_VALUES")
FILES=("$REPO_README" "$CHART" "$CHART_VALUES")
FILES_CHANGED=()

# release prep
Expand Down Expand Up @@ -54,7 +53,6 @@ HELP=$(cat << 'EOM'

Options:
-d create a draft pr
-m update versions in ReadMe only
-r target repo full name for the pr (default: aws/aws-node-termination-handler)
-h help

Expand All @@ -69,7 +67,7 @@ REPO_FULL_NAME=""
NEED_ROLLBACK=true

process_args() {
while getopts "hdmr:" opt; do
while getopts "hdr:" opt; do
case ${opt} in
h )
echo -e "$HELP" 1>&2
Expand All @@ -78,13 +76,6 @@ process_args() {
d )
DRAFT=true
;;
m )
FILES=("$REPO_README")
# release should be completed, so no longer prep
COMMIT_MESSAGE="🥑🤖 $LATEST_TAG release 🤖🥑"
PR_TITLE="🥑🤖 $LATEST_TAG release"
RELEASE_PREP=false
;;
r )
# todo: validate $REPO_FULL_NAME
REPO_FULL_NAME="${OPTARG}"
Expand Down