Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release needed? #16

Open
famarting opened this issue Mar 5, 2024 · 13 comments
Open

New release needed? #16

famarting opened this issue Mar 5, 2024 · 13 comments
Labels
bug Something isn't working

Comments

@famarting
Copy link

Describe the bug

Based on this other bug in the aws sdk aws/aws-sdk-go-v2#2370 (comment)

and looking at the release date of the only release in this repo, despite of this repo using github.com/aws/aws-sdk-go-v2 v1.19.0, it seems to me that a new release of this repo updating all the aws sdks libs is needed

Expected Behavior

the function signer.GenerateAuthTokenFromRole should not return the error failed to load credentials: unable to assume role, XXXXXXXXXXX: not found, ResolveEndpointV2

Current Behavior

I was trying the function signer.GenerateAuthTokenFromRole

and I got the error

failed to load credentials: unable to assume role, XXXXXXXXXXX: not found, ResolveEndpointV2

Reproduction Steps

can't describe the reproducer step by step, but it consists of using this library for what it was made for, you need an AWS MSK instance with IAM authentication enabled, then you need an IAM user and an IAM role in order to use all of it combined to call the function signer.GenerateAuthTokenFromRole

Possible Solution

No response

Additional Information/Context

No response

aws-msk-iam-sasl-signer-go Module Versions Used

the only one available 1.0.0

Compiler and Version used

$ go version go version go1.21.0 darwin/arm64

Operating System and version

macos sonoma 14.2

@famarting famarting added the bug Something isn't working label Mar 5, 2024
@moohyong
Copy link

i want to update this issue

@famarting
Copy link
Author

btw I can confirm this was the root cause of my issue, I was able to fix the error not found, ResolveEndpointV2 by manually updating the aws sdk dependencies, so the proper solution should consist of creating a new release of this library

@moohyong
Copy link

@famarting how to fix this issue, I found the same problem. update dependencies right?

@famarting
Copy link
Author

yes update all the aws sdk dependencies

@moohyong
Copy link

@famarting I update all dependencies but not working

Error while sending ApiVersionsRequest to broker [HOST]: failed to load credentials: unable to assume role, [ROLE] operation error STS: AssumeRole, get identity: get credentials: failed to refresh cached credentials, no EC2 IMDS role found, operation error ec2imds: GetMetadata, exceeded maximum number of attempts, 3, 

@famarting
Copy link
Author

well, that could be good, that could mean your first issue was fixed, as long as you are not seeing not found, ResolveEndpointV2 then the fix is working.... regarding the new error you are getting idk.

@famarting
Copy link
Author

famarting commented Sep 10, 2024

ping to the maintainers of this repo, can you please create a new release? We had to create a fork to solve our issue

@sankalpbhatia
Copy link
Contributor

@famarting Can you share a link or the changes you made for the forked repo?

@famarting
Copy link
Author

its just updating this modules

github.com/aws/aws-sdk-go-v2 v1.25.2
github.com/aws/aws-sdk-go-v2/config v1.27.6
github.com/aws/aws-sdk-go-v2/credentials v1.17.6
github.com/aws/aws-sdk-go-v2/service/sts v1.28.3

@yaron2
Copy link

yaron2 commented Nov 4, 2024

cc @dnwe @agarwal1510

The library is unusable at its current state and other projects depend on it

geoffmore added a commit to nicheinc/aws-msk-iam-sasl-signer-go that referenced this issue Nov 4, 2024
@agarwal1510
Copy link
Contributor

Hi @yaron2, thank you for raising the concern. Can you raise a PR with the updated dependencies which fixes the issue? I'll be happy to review and get the change merged for a new release.

@famarting
Copy link
Author

I'm on it

@famarting
Copy link
Author

#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants