-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BIO_puts and add callback function support to BIO_puts,gets,ctrl #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1721 +/- ##
=======================================
Coverage 78.29% 78.30%
=======================================
Files 580 580
Lines 96552 96618 +66
Branches 13838 13850 +12
=======================================
+ Hits 75598 75654 +56
- Misses 20341 20349 +8
- Partials 613 615 +2 ☔ View full report in Codecov by Sentry. |
skmcgrail
reviewed
Jul 25, 2024
kexgaber
changed the title
[DRAFT] Add callback function support to BIO_puts,gets,ctrl
[DRAFT] Implement BIO_puts and add callback function support to BIO_puts,gets,ctrl
Jul 25, 2024
kexgaber
changed the title
[DRAFT] Implement BIO_puts and add callback function support to BIO_puts,gets,ctrl
Implement BIO_puts and add callback function support to BIO_puts,gets,ctrl
Jul 26, 2024
skmcgrail
reviewed
Jul 29, 2024
skmcgrail
reviewed
Jul 30, 2024
skmcgrail
previously approved these changes
Jul 30, 2024
andrewhop
reviewed
Aug 1, 2024
andrewhop
approved these changes
Aug 1, 2024
skmcgrail
approved these changes
Aug 1, 2024
This was referenced Aug 1, 2024
lilpoozie2005
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-2463
Description of changes:
Currently,
BIO_puts
delegates to the publicBIO_write
API, which may result in unexpected behavior should applications rely on them being distinguishable (e.g., if a callback has certain logic for when write is called versus when puts is called). This change implements BIO_puts as its own function should this method be defined in the application, otherwise, it defaults to calling the "write" function of the type of BIO instantiated.This also expands on the work done in commit 5131684 to add support for
callback_ex
s inBIO_puts
,BIO_gets
, andBIO_ctrl
. If no custom callback_ex function is defined, the default behavior remains unchanged.Call-outs:
N/A
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.