`aws-lc-sys` v0.32.0 fails to build for musl with `fatal error: linux/random.h: No such file or directory`

[davemo88]

Problem:

build a project depending on aws-lc-sys v0.32.0 for musl targets, e.g. cargo build --target=x86_64-unknown-linux-musl fails with:
cargo:warning=/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0/aws-lc/crypto/rand_extra/urandom.c:39:10: fatal error: linux/random.h: No such file or directory

Relevant details

My Cargo.lock had v0.28.0, which still works. I'm building in docker with rust:latest image on an M4 Mac Mini.

Build log:

44.05 warning: aws-lc-sys@0.32.0: Building with: CC
44.05 warning: aws-lc-sys@0.32.0: Symbol Prefix: Some("aws_lc_0_32_0")
44.05 warning: aws-lc-sys@0.32.0: Compilation of 'c11.c' succeeded - Ok(["/worker/target/aarch64-unknown-linux-musl/release/b
uild/aws-lc-sys-9f1565ba1f5744af/out/out-c11/7dfda64fdf5a526c-c11.o"]).
44.05 warning: aws-lc-sys@0.32.0: Using flag: -ffile-prefix-map=/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557
f/aws-lc-sys-0.32.0=
44.05 warning: aws-lc-sys@0.32.0: Compilation of 'stdalign_check.c' succeeded - Ok(["/worker/target/aarch64-unknown-linux-mus
l/release/build/aws-lc-sys-9f1565ba1f5744af/out/out-stdalign_check/7dfda64fdf5a526c-stdalign_check.o"]).
44.05 warning: aws-lc-sys@0.32.0: Compilation of 'builtin_swap_check.c' succeeded - Ok(["/worker/target/aarch64-unknown-linux
-musl/release/build/aws-lc-sys-9f1565ba1f5744af/out/out-builtin_swap_check/7dfda64fdf5a526c-builtin_swap_check.o"]).
44.05 warning: aws-lc-sys@0.32.0: Compilation of 'neon_sha3_check.c' succeeded - Ok(["/worker/target/aarch64-unknown-linux-mu
sl/release/build/aws-lc-sys-9f1565ba1f5744af/out/out-neon_sha3_check/7dfda64fdf5a526c-neon_sha3_check.o"]).
44.05 warning: aws-lc-sys@0.32.0: /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0/aws-lc/cry
pto/rand_extra/urandom.c:39:10: fatal error: linux/random.h: No such file or directory
44.05 warning: aws-lc-sys@0.32.0:    39 | #include <linux/random.h>
44.05 warning: aws-lc-sys@0.32.0:       |          ^~~~~~~~~~~~~~~~
44.05 warning: aws-lc-sys@0.32.0: compilation terminated.
44.05 warning: aws-lc-sys@0.32.0: ToolExecError: command did not execute successfully (status code exit status: 1): LC_ALL="C
" "aarch64-linux-musl-gcc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-std=c11" "-I" "/usr/local/cargo/registry/s
rc/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0/generated-include" "-I" "/usr/local/cargo/registry/src/index.crates.io-
1949cf8c6b5b557f/aws-lc-sys-0.32.0/include" "-I" "/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0
.32.0/aws-lc/include" "-I" "/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0/aws-lc/third_par
ty/s2n-bignum/include" "-I" "/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0/aws-lc/third_pa
rty/s2n-bignum/s2n-bignum-imported/include" "-I" "/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0
.32.0/aws-lc/third_party/jitterentropy/jitterentropy-library" "-Wall" "-Wextra" "-Wno-unused-parameter" "-pthread" "-ffile-pr
efix-map=/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0=" "-D_XOPEN_SOURCE=700" "-DBORINGSS
L_IMPLEMENTATION=1" "-DBORINGSSL_PREFIX=aws_lc_0_32_0" "-DAWS_LC_STDALIGN_AVAILABLE=1" "-DAWS_LC_BUILTIN_SWAP_SUPPORTED=1" "-
DMY_ASSEMBLER_SUPPORTS_NEON_SHA3_EXTENSION=1" "-o" "/worker/target/aarch64-unknown-linux-musl/release/build/aws-lc-sys-9f1565
ba1f5744af/out/7bf3e571b6558a6b-urandom.o" "-c" "/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.
32.0/aws-lc/crypto/rand_extra/urandom.c"
44.05 error: failed to run custom build command for `aws-lc-sys v0.32.0`
44.05
44.05 Caused by:
44.05   process didn't exit successfully: `/worker/target/release/build/aws-lc-sys-ddf5f7807b9a24a6/build-script-main` (exit
status: 1)
...
44.05   cargo:warning=/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0/aws-lc/crypto/rand_ext
ra/urandom.c:39:10: fatal error: linux/random.h: No such file or directory
44.05   cargo:warning=   39 | #include <linux/random.h>
44.05   cargo:warning=      |          ^~~~~~~~~~~~~~~~
44.05   cargo:warning=compilation terminated.
44.05   exit status: 0
44.05   exit status: 0
44.05   exit status: 0
44.05   exit status: 0
44.05   exit status: 0
44.05   exit status: 0
44.05   exit status: 1
44.05   cargo:warning=ToolExecError: command did not execute successfully (status code exit status: 1): LC_ALL="C" "aarch64-l
inux-musl-gcc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-std=c11" "-I" "/usr/local/cargo/registry/src/index.cra
tes.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0/generated-include" "-I" "/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b
557f/aws-lc-sys-0.32.0/include" "-I" "/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0/aws-lc
/include" "-I" "/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0/aws-lc/third_party/s2n-bignu
m/include" "-I" "/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0/aws-lc/third_party/s2n-bign
um/s2n-bignum-imported/include" "-I" "/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0/aws-lc
/third_party/jitterentropy/jitterentropy-library" "-Wall" "-Wextra" "-Wno-unused-parameter" "-pthread" "-ffile-prefix-map=/us
r/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0=" "-D_XOPEN_SOURCE=700" "-DBORINGSSL_IMPLEMENTA
TION=1" "-DBORINGSSL_PREFIX=aws_lc_0_32_0" "-DAWS_LC_STDALIGN_AVAILABLE=1" "-DAWS_LC_BUILTIN_SWAP_SUPPORTED=1" "-DMY_ASSEMBLE
R_SUPPORTS_NEON_SHA3_EXTENSION=1" "-o" "/worker/target/aarch64-unknown-linux-musl/release/build/aws-lc-sys-9f1565ba1f5744af/o
ut/7bf3e571b6558a6b-urandom.o" "-c" "/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0/aws-lc/
crypto/rand_extra/urandom.c"

[davemo88]

minimal reproduction:

https://github.com/davemo88/aws-lc-sys-musl-build-failure

[OtaK]

Same issue here

[justsmth]

Hello! I apologize for this build failure. Thanks for reporting it and for the minimal reproduction setup. There were several recent changes upstream in AWS-LC related to entropy/randomness. This is likely related to that.

I’ll take a closer look in the morning and hopefully have another patch release out to fix it soon. Thanks again!

[justsmth]

One thing I noticed in the logs is that the compiler used is called “aarch64-linux-musl-gcc”, which seems to conflict with the stated target of “ x86_64-unknown-linux-musl”. I made an upstream PR awhile back (I’ll need to find the link) to cc-rs that affected how the musl compiler is identified. I wonder whether more than one change occurred that's causing this to surface now?

EDIT: It was this PR: rust-lang/cc-rs#1443

[davemo88]

One thing I noticed in the logs is that the compiler used is called “aarch64-linux-musl-gcc”, which seems to conflict with the stated target of “ x86_64-unknown-linux-musl”. I made an upstream PR awhile back (I’ll need to find the link) to cc-rs that affected how the musl compiler is identified. I wonder whether more than one change occurred that's causing this to surface now?

EDIT: It was this PR: rust-lang/cc-rs#1443

Heya - for me it fails on both arm and x86. aarch64 is when I'm building on my Mac desktop and x86 I first noticed when a GitHub Action failed. I noticed because I wasn't using my workspace's Cargo.lock in the GHA build so it pulled the newer version.

[torben-hansen]

This https://github.com/aws/aws-lc/blob/main/crypto/rand_extra/urandom.c#L39 used to be conditioned on the FIPS build. But no more. So, now the build requires kernel header, which you probably don't have, tripping the builds(?)

At least, that's my current working hypothesis.

[davemo88]

This https://github.com/aws/aws-lc/blob/main/crypto/rand_extra/urandom.c#L39 used to be conditioned on the FIPS build. But no more. So, now the build requires kernel header, which you probably don't have, tripping the builds(?)

Right, afaik that header isn't available for musl.

[davemo88]

https://github.com/davemo88/aws-lc-sys-musl-build-failure/pull/1/files

this fixed the build but I don't fully understand why or if this is a good solution

[Esgrove]

Same. This aws-lc-sys has been causing a lot of headaches for us in multiple Rust projects after it got put into AWS SDK crates 😢

[aajtodd]

Causing regression in AWS SDK for Rust canaries

[justsmth]

Causing regression in AWS SDK for Rust canaries

I apologize for this operational pain. I'll try to get this PR for the fix merged quickly, and an AWS-LC release out soon after that. Then we will import that release into aws-lc-sys.

I'll try to get this completed quickly, but it'll likely be Monday before a new release is out. I'll post here as soon as the new release is published.