Skip to content

Fix Formatting override being ignored. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025
Merged

Fix Formatting override being ignored. #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42f5b28
Add missing level_override instance variable to logger #initialize
Jun 4, 2025
32649ec
Fix Formatter Override Being Ignored.
Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/aws_lambda_ric/logger_patch.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,16 @@ module LoggerPatch
def initialize(logdev, shift_age = 0, shift_size = 1048576, level: 'debug',
progname: nil, formatter: nil, datetime_format: nil,
binmode: false, shift_period_suffix: '%Y%m%d')
logdev_lambda_overwrite = logdev
logdev_lambda_override = logdev
formatter_override = formatter
# use unpatched constructor if logdev is a filename or an IO Object other than $stdout or $stderr
if !logdev || logdev == $stdout || logdev == $stderr
logdev_lambda_overwrite = AwsLambdaRIC::TelemetryLogger.telemetry_log_sink
@default_formatter = LogFormatter.new
logdev_lambda_override = AwsLambdaRIC::TelemetryLogger.telemetry_log_sink
formatter_override = LogFormatter.new
end

super(logdev_lambda_overwrite, shift_age, shift_size, level: level, progname: progname,
formatter: formatter, datetime_format: datetime_format,
super(logdev_lambda_override, shift_age, shift_size, level: level, progname: progname,
formatter: formatter_override, datetime_format: datetime_format,
binmode: binmode, shift_period_suffix: shift_period_suffix)
end
end