Add support for otfMetadata in Kinesis firehose response metadata for Iceberg routing #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… iceberg table routing
Smelton01
force-pushed
the
support-otf-metadata
branch
from
2177d5c to
5ec6ac4
Compare
bmoffatt
reviewed
Oct 3, 2025
events/firehose.go
Outdated
|
|
||
| // Constants used for otf operation for the record | ||
| const ( | ||
| KinesisFirehoseOTFOperationInsert = "insert" |
There was a problem hiding this comment.
Expected type KinesisFirehoseOTFOperation string, like is done elsewhere for similar enum-likes in other events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #575
Description of changes: Add support for otfMetadata in Kinesis firehose response metadata for Iceberg routing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
There are a couple of other PRs open regarding this but there has been not activity for a while.
This is a relatively simple change that is preventing us from properly using the Iceberg integration with the firehose transformation and from my testing, the transformation still works as expected with/without the OTF metadata provided.