Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: use var instead of const #412

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Conversation

robberfree
Copy link
Contributor

should keep code as es5 across files. If mixed es5 and es6 code, it' hard to compile or not in build tool like webpack. maybe has the same issue in somewhere, please double check.

should keep code as es5 across files. If mixed es5 and es6 code, it' hard to compile or not in build tool like webpack. maybe has the same issue in somewhere, please double check.
@jmklix
Copy link
Member

jmklix commented Aug 5, 2022

Can you add a more detailed explanation of why you made this change? and show how it makes it easier to compile/build.

@jmklix jmklix added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 5, 2022
@robberfree
Copy link
Contributor Author

hi @jmklix.
I use aws-iot-device-sdk-js as a dependency and use webpack as build tool. As aws-iot-device-sdk-js is a dependency i think all the code are es5, so i don't compile it by webpack. That works well most time even it has some es6 code(const/let).But when the platform i targeted requested that all code must be es5, that will be a problem. That means i must use webpack to compile whole aws-iot-device-sdk-js/device folder even there is only one line es6 code in this folder.

what i means why keep all code are es5? i check the files most are es5 only a little are es6.

@TwistedTwigleg TwistedTwigleg removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 9, 2022
@TwistedTwigleg
Copy link
Contributor

Thank you for making this PR! Merging into main...

@TwistedTwigleg TwistedTwigleg merged commit ff4cf75 into aws:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants