test: initial commit of ESDK TestVectors - #678
Merged
Merged
Conversation
josecorella
force-pushed
the
jocorell/dafny-test-vectors
branch
from
September 27, 2024 23:08
c70b655 to
bdbfcf8
Compare
josecorella
had a problem deploying
to
Duvet CI
September 27, 2024 23:08 — with 
GitHub Actions
Failure
GitHub Actions
Failure
josecorella
temporarily deployed
to
Duvet CI
September 30, 2024 17:44 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
josecorella
temporarily deployed
to
Duvet CI
September 30, 2024 23:01 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
seebees
reviewed
Nov 5, 2024
seebees
reviewed
Nov 5, 2024
seebees
reviewed
Nov 5, 2024
seebees
reviewed
Nov 5, 2024
seebees
reviewed
Nov 11, 2024
seebees
reviewed
Nov 11, 2024
seebees
suggested changes
Nov 11, 2024
seebees
left a comment
seebees
left a comment
Contributor
There was a problem hiding this comment.
I think we should also order the test vectors.
I'm thinking something like:
description, algorithmSuiteId
seebees
previously approved these changes
Nov 13, 2024
seebees
left a comment
seebees
left a comment
Contributor
There was a problem hiding this comment.
LGTM left one nit for later :)
Comment on lines
+170
to
+172
| predicate DescriptionLessThan(x: EsdkTestVectors.EsdkEncryptTestVector, y: EsdkTestVectors.EsdkEncryptTestVector) { | ||
| Below(x.description, y.description) | ||
| } |
Contributor
There was a problem hiding this comment.
Likely too much work ATM, but we should come back and change this to:
Suggested change
| predicate DescriptionLessThan(x: EsdkTestVectors.EsdkEncryptTestVector, y: EsdkTestVectors.EsdkEncryptTestVector) { | |
| Below(x.description, y.description) | |
| } | |
| predicate DescriptionLessThan(x: EsdkTestVectors.EsdkEncryptTestVector, y: EsdkTestVectors.EsdkEncryptTestVector) { | |
| && Below(x.description, y.description) | |
| && Below(x.algorithmSuiteId, y.algorithmSuiteId) | |
| } |
I know that this might be complicated so I won't block on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.