test(test_vectors): Support reading manifests that specify a hierarchy keyring - #649
Merged
Conversation
RitvikKapila
marked this pull request as ready for review
June 28, 2024 18:18
RitvikKapila
marked this pull request as draft
June 28, 2024 18:19
RitvikKapila
marked this pull request as ready for review
June 28, 2024 20:10
RitvikKapila
marked this pull request as draft
June 28, 2024 20:10
RitvikKapila
changed the title
lucasmcdonald3
temporarily deployed
to
Duvet CI
October 2, 2024 23:09 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
lucasmcdonald3
commented
Oct 2, 2024
…MaterialProviderFactory.cs
lucasmcdonald3
changed the title
lucasmcdonald3
temporarily deployed
to
Duvet CI
October 2, 2024 23:11 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
October 2, 2024 23:45 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
October 2, 2024 23:50 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
October 2, 2024 23:51 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
October 2, 2024 23:51 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
October 2, 2024 23:55 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
October 3, 2024 00:00 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
lucasmcdonald3
changed the title
lucasmcdonald3
marked this pull request as ready for review
October 3, 2024 00:30
josecorella
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Support reading manifests that specify a hierarchy keyring.
This is a breaking-ish change.
The MPL TestVectors project is now a required dependency for the native .NET ESDK TestVector runner.
The MPL TestVectors creates a "special" local hierarchical keyring. Languages that want to test interop with other implementations of this "special" keyring must use the MPL TestVectors project.
Testing
This repo does not test any manifests that specify a hierarchical keyring. Only ESDK-Python does this right now.
ESDK-Python has a test that:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.