chore: Change MPL branch, remove PYTHONPATH workarounds - #683
Merged
Conversation
lucasmcdonald3
changed the title
lucasmcdonald3
changed the title
lucasmcdonald3
changed the title
lucasmcdonald3
changed the title
lucasmcdonald3
marked this pull request as ready for review
August 2, 2024 13:54
lucasmcdonald3
force-pushed
the
lucmcdon/mpl-v2
branch
from
August 2, 2024 14:00
ed4eb8e to
b450538
Compare
lucasmcdonald3
commented
Aug 2, 2024
lucasmcdonald3
commented
Aug 2, 2024
lucasmcdonald3
commented
Aug 2, 2024
lucasmcdonald3
commented
Aug 2, 2024
lucasmcdonald3
commented
Aug 2, 2024
RitvikKapila
reviewed
Aug 5, 2024
RitvikKapila
left a comment
RitvikKapila
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me. Just one thing, I think you missed one of the examples: https://github.com/aws/aws-encryption-sdk-python/blob/lucmcdon/mpl-v2/examples/src/default_cryptographic_materials_manager_example.py for removing the sys.path.append commands.
lucasmcdonald3
added a commit
that referenced
this pull request
Aug 6, 2024
lucasmcdonald3
added a commit
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: