chore: performance tests for ESDK-python - #680
Merged
Merged
Conversation
lucasmcdonald3
left a comment
lucasmcdonald3
left a comment
Contributor
There was a problem hiding this comment.
What's your plan for running this in CI?
I wonder if you can put this in GHA...
Contributor
Author
Currently for CI, I'm thinking of putting this in CodeBuild for consistency with other tests using MPL. |
| return click.testing.CliRunner() | ||
|
|
||
|
|
||
| def test_create(runner): |
Contributor
There was a problem hiding this comment.
[curious] how much work would it be to print out the summary statistics to the codebuild logs?
Contributor
Author
There was a problem hiding this comment.
We would be calling the consolidate results script.
It would basically mean running the consolidate_results.py script from the test python files for each of the tests.
lucasmcdonald3
approved these changes
Jun 5, 2024
lucasmcdonald3
pushed a commit
that referenced
this pull request
Aug 6, 2024
lucasmcdonald3
pushed a commit
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Performance tests for ESDK-python for comparison between keyrings and master key providers based on execution time and memory used.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: