feat: Required encryption context CMM - #645
Merged
Merged
Conversation
lucasmcdonald3
marked this pull request as ready for review
March 26, 2024 23:41
lucasmcdonald3
commented
Apr 15, 2024
lucasmcdonald3
commented
Apr 16, 2024
seebees
suggested changes
Apr 17, 2024
seebees
left a comment
seebees
left a comment
Contributor
There was a problem hiding this comment.
The default CMM, or really any CMM should be able to handle reproduced EC. We may need to re-think how we want to expose the Default CMM in this new world.
1 task
1 task
ajewellamz
reviewed
Apr 22, 2024
|
|
||
| from .example_branch_key_id_supplier import ExampleBranchKeyIdSupplier | ||
|
|
||
| # TODO-MPL: Remove this as part of removing PYTHONPATH hacks. |
Contributor
There was a problem hiding this comment.
I assume this TODO is not yet TO BE DONE?
Contributor
Author
There was a problem hiding this comment.
This is still TODO. I have to:
- Update Dafny compiler to support outer-module
- Update Smithy-Dafny to reference outer-module
- Update MPL to use outer-module
I'm tracking that work separately.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: