Remove local caching and conversion to uintptr #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achevuru
reviewed
Aug 23, 2024
achevuru
reviewed
Aug 23, 2024
jayanthvn
force-pushed
the
refactor_update
branch
2 times, most recently
from
5ee4bb7
to
d28ba28
Compare
jayanthvn
force-pushed
the
refactor_update
branch
from
d6fee34
to
3b3e0b1
Compare
achevuru
approved these changes
Aug 26, 2024
jayanthvn
added a commit
that referenced
this pull request
Aug 29, 2024
* Fixup update flow (#88) * Bump golang.org/x/sys from 0.20.0 to 0.24.0 (#89) Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.20.0 to 0.24.0. - [Commits](golang/sys@v0.20.0...v0.24.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix test on rel-branch --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jayanthvn
added a commit
that referenced
this pull request
Nov 5, 2024
* Use default error formating instead of wrap when errors.Wrap isn't implemented.
Use default error formatting when the error wrap isn't available.
The error message that was seen was
```{"level":"error","ts":"2024-06-30T10:52:42.597Z","caller":"ebpf/bpf_client.go:563","msg":"failed to find device by name eni3d4ff16416b: %!w(netlink.LinkNotFoundError={0xc0007ae7c0})"}
```
* Fixup update flow (#88)
* Bump golang.org/x/sys from 0.20.0 to 0.24.0 (#89)
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.20.0 to 0.24.0.
- [Commits](golang/sys@v0.20.0...v0.24.0)
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix test on rel-branch
* Log the return error no from syscall
* Fix PR checks
Fix PR checks
* fix go dependencies.
* fix go.sum dependencies.
* Bump github.com/vishvananda/netlink from 1.1.0 to 1.3.0
Bumps [github.com/vishvananda/netlink](https://github.com/vishvananda/netlink) from 1.1.0 to 1.3.0.
- [Release notes](https://github.com/vishvananda/netlink/releases)
- [Commits](vishvananda/netlink@v1.1.0...v1.3.0)
---
updated-dependencies:
- dependency-name: github.com/vishvananda/netlink
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <[email protected]>
* Updated go.mod dependencies.
* Bump golang.org/x/sys from 0.24.0 to 0.26.0
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.24.0 to 0.26.0.
- [Commits](golang/sys@v0.24.0...v0.26.0)
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <[email protected]>
* updated go mod and go sum.
* added GetBPFmapInfo method to support PIN_NONE where pinpath does not exist (#96)
Co-authored-by: Nithish Kumar Murcherla <[email protected]>
---------
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Senthil Kumaran <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jay Deokar <[email protected]>
Co-authored-by: Yash Thakkar <[email protected]>
Co-authored-by: Senthil Kumaran <[email protected]>
Co-authored-by: Nithish Murcherla <[email protected]>
Co-authored-by: Nithish Kumar Murcherla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Bulk update refresh caches the input and converts String to byte ptr. On high scale, the byte ptr is getting GC'ed and data is invalid which would cause update to fail.
With fix -
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.