Skip to content

fix: add timeout fields to callback started event #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangyb-A merged 1 commit into from
Nov 28, 2025
Merged

fix: add timeout fields to callback started event #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install Hatch
run: |
python -m pip install --upgrade hatch
python -m pip install hatch==1.15.0
- uses: webfactory/[email protected]
with:
ssh-private-key: ${{ secrets.SDK_KEY }}
Expand Down
17 changes: 16 additions & 1 deletion src/aws_durable_execution_sdk_python_testing/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2118,6 +2118,17 @@ def create_callback_event_started(cls, context: EventCreationContext) -> Event:
callback_id: str | None = (
callback_details.callback_id if callback_details else None
)
callback_options: CallbackOptions | None = (
context.operation_update.callback_options
if context.operation_update
else None
)
timeout: int | None = (
callback_options.timeout_seconds if callback_options else None
)
heartbeat_timeout: int | None = (
callback_options.heartbeat_timeout_seconds if callback_options else None
)
return cls(
event_type=EventType.CALLBACK_STARTED.value,
event_timestamp=context.start_timestamp,
Expand All @@ -2126,7 +2137,11 @@ def create_callback_event_started(cls, context: EventCreationContext) -> Event:
operation_id=context.operation.operation_id,
name=context.operation.name,
parent_id=context.operation.parent_id,
callback_started_details=CallbackStartedDetails(callback_id=callback_id),
callback_started_details=CallbackStartedDetails(
callback_id=callback_id,
timeout=timeout,
heartbeat_timeout=heartbeat_timeout,
),
)

@classmethod
Expand Down
Loading