Skip to content

chore: move put cache after signature verification #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rishav-karanjit merged 2 commits into from
Apr 16, 2026
Merged

chore: move put cache after signature verification #2223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
095aeff
move put cache
rishav-karanjit Apr 16, 2026
2fa7c98
m
rishav-karanjit Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...v2/com/amazonaws/services/dynamodbv2/datamodeling/sdkv2/encryption/DynamoDBEncryptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@ public Map<String, AttributeValue> decryptRecord(
materials.getVerificationKey(),
signature
);
DynamoDbSigner.putCacheIfEmpty(signer);
itemAttributes.remove(materialDescriptionFieldName);

actualDecryption(
Expand Down
5 changes: 4 additions & 1 deletion ...sdkv2/com/amazonaws/services/dynamodbv2/datamodeling/sdkv2/encryption/DynamoDbSigner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,14 @@ static DynamoDbSigner getInstance(String signingAlgorithm, SecureRandom rnd) {
DynamoDbSigner result = cache.get(signingAlgorithm);
if (result == null) {
result = new DynamoDbSigner(signingAlgorithm, rnd);
cache.putIfAbsent(signingAlgorithm, result);
}
return result;
}

static void putCacheIfEmpty(DynamoDbSigner signer) {
cache.putIfAbsent(signer.getSigningAlgorithm(), signer);
}

/**
* @param signingAlgorithm is the algorithm used for asymmetric signing (ex: SHA256withRSA). This
* is ignored for symmetric HMACs as that algorithm is fully specified by the key.
Expand Down
Loading