Repository navigation
chore(java): shut down local DDB in test #2176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
61b0281
m
rishav-karanjit c764ee0
Merge branch 'main' into tearDownLocalDDB
rishav-karanjit 56380dd
empty commit to run semantic commit once again
rishav-karanjit 3a2fd57
merge
rishav-karanjit 5a8af7c
Merge branch 'main' into tearDownLocalDDB
rishav-karanjit da268bc
m
rishav-karanjit 1b013bd
Merge branch 'tearDownLocalDDB' of github.com:aws/aws-database-encryp…
rishav-karanjit 53778e7
Need to clean up table per method
rishav-karanjit 6512d9d
m
rishav-karanjit 7451fdf
m
rishav-karanjit 2177c95
m
rishav-karanjit 5c1b774
m
rishav-karanjit 0360ac2
m
rishav-karanjit 2d515fd
m
rishav-karanjit 985600c
Merge branch 'main' into tearDownLocalDDB
rishav-karanjit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to shut down ddb local after each test method? If yes, can you explain why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @AfterMethod is intentional here. The @BeforeMethod setup() creates a new DynamoDB Local client and @AfterMethod is doing the reverse as its consuming a lot of memory without shutting it down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The crux of question is that do we need DB local to be created after each test method? Why can't we setup DB local for a test class and do setup/teardown after the test class is complete. This practice is seen on other test cases in the same PR.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point — I've refactored CachingMostRecentProviderTests to create the DDB Local client once in BeforeClass and shut it down in AfterClass, with table create/delete per method for test isolation as test expects it.
For TransformerHolisticIT, the refactor of interop test takes longer — the parameterized tests expect fresh DDB Local instance to get a completely clean database per scenario, and converting that to a shared client would require refactoring of interop test. Since we plan to delete sdkv1 anyway, I did not refactor all of the interop test.