Skip to content

chore: update readme and remove comments in CI #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rishav-karanjit merged 2 commits into from
Mar 24, 2026
+2 −2
Merged

chore: update readme and remove comments in CI #2158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5617129
update readme
rishav-karanjit Mar 24, 2026
6bc904f
uncomment
rishav-karanjit Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci_examples_java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ jobs:
working-directory: ./Examples
run: |
# Run simple examples
# TODO -- remove this
# gradle -p runtimes/java/DynamoDbEncryption test
gradle -p runtimes/java/DynamoDbEncryption test
gradle -p runtimes/java/DDBECwithSDKV2 test
# Run migration examples
gradle -p runtimes/java/Migration/PlaintextToAWSDBE test
Expand Down
1 change: 1 addition & 0 deletions DynamoDbEncryption/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Within `runtimes/java`:
- `src/main/java` contains all hand written Java code, including externs.
- `src/main/dafny-generated` contains all Dafny to Java transpiled code.
- `src/main/smithy-generated` contains all Smithy to Java generated code.
- `src/main/sdkv2` contains an embedded copy of the DynamoDB Encryption Client (DDBEC), which can be used as a standalone DDBEC or during migration from DDBEC to the DB-ESDK.

@josecorella josecorella Mar 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are including also the sdkv1 version you should either include that bullet point or just completeky remove this entry


#### .NET

Expand Down
Loading